Skip to content

analogReference: add getter for AR_INTERNAL if defined at variant level #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2023
Merged

analogReference: add getter for AR_INTERNAL if defined at variant level #190

merged 1 commit into from
Nov 16, 2023

Conversation

facchinm
Copy link
Member

No description provided.

@facchinm facchinm requested a review from sebromero November 15, 2023 10:41
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Nov 15, 2023
sebromero
sebromero requested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, but the ifdef is redundant, see comment.

@per1234 per1234 added type: imperfection Perceived defect in any part of project and removed type: enhancement Proposed improvement labels Nov 16, 2023
@facchinm facchinm requested a review from sebromero November 16, 2023 08:57
sebromero
sebromero approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebromero sebromero merged commit 684cafc into arduino:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebromero sebromero sebromero approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@facchinm @sebromero @per1234